Skip to content

Conversation

@cbachhuber
Copy link
Contributor

@cbachhuber cbachhuber commented Dec 10, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

Fixing part of https://github.com/alexeagle/rules-doctor/actions/runs/20065968971/job/57554491288#step:6:1

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • [] No

Might possibly make other PRs unmergeable when it's merged.

Other information

@aspect-workflows
Copy link

aspect-workflows bot commented Dec 10, 2025

Test

All tests were cache hits

1 test (100.0%) was fully cached saving 50ms.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Contributor

@hofbi hofbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conventional commits are required for

# Tag a new release using https://github.com/marketplace/actions/conventional-commits-versioner-action
to work correctly so having this enforced is super helpful.

We use this workflow in many places such as https://github.com/bazel-contrib/bazelrc-preset.bzl/blob/main/.github/workflows/conventional-commits.yaml or https://github.com/bazel-contrib/bazel-lib/blob/main/.github/workflows/conventional-commits.yaml

@alexeagle alexeagle merged commit 4a81213 into bazel-contrib:main Dec 10, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants